Export dbus address for the notification server #23
Conversation
qubes-rpc/services/qvc.ScreenShare
Outdated
| DISPLAY=:0 | ||
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | ||
| export DISPLAY DBUS_SESSION_BUS_ADDRESS |
There was a problem hiding this comment.
| DISPLAY=:0 | |
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | |
| export DISPLAY DBUS_SESSION_BUS_ADDRESS | |
| set -eu | |
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | |
| export DISPLAY=:0 DBUS_SESSION_BUS_ADDRESS |
qubes-rpc/services/qvc.Webcam
Outdated
| DISPLAY=:0 | ||
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | ||
| export DISPLAY DBUS_SESSION_BUS_ADDRESS |
There was a problem hiding this comment.
| DISPLAY=:0 | |
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | |
| export DISPLAY DBUS_SESSION_BUS_ADDRESS | |
| set -eu | |
| DBUS_SESSION_BUS_ADDRESS="unix:path=/run/user/$(id -u)/bus" | |
| export DISPLAY=:0 DBUS_SESSION_BUS_ADDRESS |
|
Should |
Not necessary but nice to have and be the base path of DBUS_SESSION_BUS_ADDRESS. Will do. |
There was a problem hiding this comment.
Don't override those unconditionally. Set only if not present already.
Especially, if user session is running (and so is qrexec-fork-server), they should be provided already. There may be cases when either of them have different value (like in GUI domain that runs full desktop env)
Only screenshare script requires as of today, but put it in webcam also for future proof as it doesn't cause any harm. Assigning variable and declaration made separate due to ShellCheck warning SC2155. For: QubesOS/qubes-issues#6426 Fixes: QubesOS/qubes-issues#8457 Fixes: https://github.com/QubesOS/qubes-video-companion/issues/15
Done.
Unfortunately they were not set and many users, including me, encountered that issue. Now it is using the existent value if set, else fallback. |
Only screenshare script requires as of today, but put it in webcam also for future proof as it doesn't cause any harm.
Assigning variable and declaration made separate due to ShellCheck warning SC2155.
For: QubesOS/qubes-issues#6426
Fixes: QubesOS/qubes-issues#8457
Fixes: https://github.com/QubesOS/qubes-video-companion/issues/15